[Webkit-unassigned] [Bug 54080] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54080


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81959|review?                     |review+
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-02-10 09:23:32 PST ---
(From update of attachment 81959)
View in context: https://bugs.webkit.org/attachment.cgi?id=81959&action=review

Looks good to me! I wouldn't mind Amruth taking another look at it too.

> Source/WebKit2/Shared/gtk/UpdateChunk.cpp:112
> +    return cairo_image_surface_create_for_data(reinterpret_cast<unsigned char*>(m_sharedMemory->data()),

This should just be a static cast, I think.

> Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:106
> +    // BackingStore

Please remove this comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.