[Webkit-unassigned] [Bug 54198] [GTK] Log signals from AtkDocument interface also in AccessibilityController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54198


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81976|review?                     |review+
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2011-02-10 09:17:36 PST ---
(From update of attachment 81976)
View in context: https://bugs.webkit.org/attachment.cgi?id=81976&action=review

Great. Please incorporate the following suggestions.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:36
> +#include "DumpRenderTree.h"
> +#include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
> +
> +#include <gtk/gtk.h>

No empty line needed here.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:65
> +    gchar* actualObjectName = 0;
> +    if (!objectName || *objectName == '\0')
> +        actualObjectName = g_strdup("(No name)");
> +    else
> +        actualObjectName = g_strdup(objectName);
> +

I think you can just do this:
if (!objectName || *objectName == '\0')
    objectName = "No name";

and avoid some extra code.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:86
> +    gchar* signalName = 0;

You can use GOwnPtr here.

> Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp:102
> +    } else {
> +        signalName = g_strdup(signal_query.signal_name);
> +    }

No curlies here since this is only one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.