[Webkit-unassigned] [Bug 54211] New: WKPageFindClient::didFindString is never called if kWKFindOptionsShowOverlay is not passed to WKPageFindString

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54211

           Summary: WKPageFindClient::didFindString is never called if
                    kWKFindOptionsShowOverlay is not passed to
                    WKPageFindString
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: sullivan at apple.com, andersca at apple.com, sam at webkit.org


If an application calls WKPageFindString, but doesn't pass the kWKFindOptionsShowOverlay flag, the find client's didFindString callback is never called.

You can see in the implementation of FindController::findString that the DidFindString message is only sent if shouldShowOverlay is true. [1]

It seems like either didFindString is misnamed, or we should be calling it even when we're not showing the overlay.

1. http://trac.webkit.org/browser/trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp?rev=77862#L104

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.