[Webkit-unassigned] [Bug 54116] [GTK] Add support in DRT to log "accessibility events"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54116





--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2011-02-10 00:49:59 PST ---
(In reply to comment #4)
> (From update of attachment 81867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81867&action=review
> 
> r=me
>

Thanks for the quick review!

> > Tools/DumpRenderTree/AccessibilityController.cpp:86
> > +
> 
> Seems like this should take an argument (true/false) so you can turn this on or off

I just followed the same pattern I've seen for other functions, such as logFocusEvents and logValueChangeEvents: you just enable the feature once per test (with accessibilityController.logAccessibilityEvents()) and it gets always reset in the AccessibilityController::resetToConsistentState() method.

I think that's enough for this cases, but if you (well, or somebody else) think it would be better to add that extra flexibility just file a bug, or ask me to do it so, and I gladly add that feature as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.