[Webkit-unassigned] [Bug 50126] Fallback content in canvas element not focusable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50126





--- Comment #7 from chris fleizach <cfleizach at apple.com>  2011-02-09 23:07:47 PST ---
(From update of attachment 81856)
View in context: https://bugs.webkit.org/attachment.cgi?id=81856&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3283
>      

The default for allowing children is true. I don't think canvas fits any of the roles that don't allow children, so it seems this is not necessary

> Source/WebCore/html/HTMLFormControlElement.cpp:243
>          return false;

Instead of removing the size check, which may be valid in other contexts, should you just add another check to determine if its size is empty and it's not a child of a canvas area.

> Source/WebCore/rendering/RenderObject.cpp:1317
>  }

Might be a good idea to have a comment why this changed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.