[Webkit-unassigned] [Bug 53925] AssociatedURLLoader does not support Cross Origin Requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53925


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-02-09 17:39:58 PST ---
Attachment 81901 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Last 3072 characters of output:
 so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:88:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:89:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:90:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:91:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:92:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:93:  The parameter name "loader" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:93:  The parameter name "error" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:97:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:121:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:174:  web_error is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:202:  webcore_request is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:203:  webcore_document is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:216:  webcore_request is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.cpp:217:  webcore_document is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit/chromium/src/AssociatedURLLoader.h:58:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.h:59:  One space before end of line comments  [whitespace/comments] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.h:66:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.h:67:  The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/AssociatedURLLoader.h:67:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 26 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.