[Webkit-unassigned] [Bug 54154] File uploads do not work within the sandbox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54154


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81895|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-02-09 17:00:51 PST ---
(From update of attachment 81895)
View in context: https://bugs.webkit.org/attachment.cgi?id=81895&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2124
> +        SandboxExtension::Handle sandboxExtensionHandle;
> +        SandboxExtension::createHandle(fileURLs[i], SandboxExtension::ReadOnly, sandboxExtensionHandle);

Why does this use an out argument instead of a return value?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1561
> +    RefPtr<SandboxExtension> extension = SandboxExtension::create(handle);
> +    extension->consumePermanently();

No need for a local variable here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.