[Webkit-unassigned] [Bug 54103] Implement fast path for matching simple selectors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54103


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81885|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-02-09 16:02:36 PST ---
(From update of attachment 81885)
View in context: https://bugs.webkit.org/attachment.cgi?id=81885&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:365
> +    bool canFastCheckSelector() const { return m_canFastCheckSelector; }
> +    bool hasMultipartSelector() const { return m_hasMultipartSelector; }
> +    bool topHTMLSelectorMatchesBasedOnRuleHash() const { return m_topHTMLSelectorMatchesBasedOnRuleHash; }

When possible I prefer booleans that read like sentences “rule data <xxx>”. The first and third names here don’t really work that way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.