[Webkit-unassigned] [Bug 52712] Add a compile-time option to disable WebArchive support

Wed Feb 9 14:33:29 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52712

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80633|review?                     |review+
               Flag|                            |

--- Comment #24 from Adam Barth <abarth at webkit.org>  2011-02-09 14:33:28 PST ---
(From update of attachment 80633)
View in context: https://bugs.webkit.org/attachment.cgi?id=80633&action=review

This looks good to me, but I'm not a WebArchive expert.  I've been avoiding reviewing this patch because folks pointed out errors in my previous review.  However, no one else seems to be reviewing this patch...  Maybe give folks some time to take another look before landing?

> Source/WebCore/ChangeLog:15
> +            WebArchive support is currently enabled for all ports that define PLATFORM(CF) apart from QT.

QT => Qt

> Source/WebCore/WebCore.gyp/WebCore.gyp:1348
> +        # Don't build files needed for WebArchive support. Since we disable
> +        # this feature.

The second sentence here isn't a complete sentence.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.