[Webkit-unassigned] [Bug 54066] [NRWT] Remove encoding parameters in rebaseline.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 13:49:29 PST 2011


--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2011-02-09 13:49:29 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > As long as nothing breaks, I guess this change is fine, but I still feel kind of uncomfortable about it. Perhaps we should also change the expected_text() and expected_checksum() methods in port/base.py to use read_binary_file() instead of read_text_file()?
> expected_text() already uses read_binary_file().  expected_checksum() could use either since it's just reading ascii.  It's probably a bit safer to use read_text_file(), but I don't feel strongly one way or another.

You're right. Apparently I can't read. Anyway, I would feel better if we changed expected_checksum() to use read_binary_file() as well, for consistency.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list