[Webkit-unassigned] [Bug 53728] indexeddb: make setVersion fire blocked event if other connections are open

Wed Feb 9 13:30:26 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=53728

--- Comment #8 from David Grogan <dgrogan at chromium.org>  2011-02-09 13:30:27 PST ---
(From update of attachment 81565)
View in context: https://bugs.webkit.org/attachment.cgi?id=81565&action=review

>> LayoutTests/storage/indexeddb/set_version_blocked.html:1
>> +<html>
> 
> You need to create expected results.

done

>> LayoutTests/storage/indexeddb/set_version_blocked.html:20
>> +    if ('webkitIndexedDB' in window) {
> 
> no {} for one liner

done

>> LayoutTests/storage/indexeddb/set_version_blocked.html:58
>> +function setVersion(tries) {
> 
> newline

done

>> LayoutTests/storage/indexeddb/set_version_blocked.html:65
>> +function unexpectedBlockCallback() {
> 
> put in the shared.js file...and call it "Blocked" not "Block"

done

>> Source/WebCore/dom/EventTarget.h:143
>> +        virtual IDBVersionChangeRequest* toIDBVersionChangeRequest();
> 
> alpha order

done

>> Source/WebCore/storage/IDBDatabase.cpp:135
>> +    if (m_noNewTransactions)
> 
> Stuff like this should be tested in the layout test.

done

>> Source/WebCore/storage/IDBDatabaseBackendImpl.h:65
>> +    virtual void open();
> 
> You'll need to add this to the WebKit:: stuff.

This round?  It seems that nothing would use it when only doing ref counting.

>> Source/WebCore/storage/IDBRequest.cpp:190
>> +void IDBRequest::scheduleBlockedEvent()
> 
> You need to sync your repo.  This has all changed a bunch.

done

>> Source/WebCore/storage/IDBVersionChangeRequest.h:32
>> +#include "Timer.h"
> 
> Why is this needed?

it's not, deleted

>> Source/WebCore/storage/IDBVersionChangeRequest.h:33
>> +#include <wtf/Vector.h>
> 
> why is this needed?

it's not, deleted

>> Source/WebCore/storage/IDBVersionChangeRequest.h:37
>> +class IDBTransactionBackendInterface;
> 
> why is this needed?

it's not, deleted

>> Source/WebCore/storage/IDBVersionChangeRequest.h:41
>> +    static PassRefPtr<IDBVersionChangeRequest> create(ScriptExecutionContext* context, PassRefPtr<IDBAny> source) { return adoptRef(new IDBVersionChangeRequest(context, source)); }
> 
> lately i've been shying away from inlining these.  Maybe move it?

I'm a fan of "no implementation in the .h files"; moved.

>> Source/WebCore/storage/IDBVersionChangeRequest.h:43
>> +    virtual void onBlocked();
> 
> usually we do a newline between the constructor/destructor stuff and other stuff

done

>> Source/WebCore/storage/IDBVersionChangeRequest.h:49
>> +
> 
> no blank line

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.