[Webkit-unassigned] [Bug 50969] <option> should support the dir attribute and be displayed accordingly both in the dropdown and after being chosen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50969





--- Comment #18 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-09 13:29:17 PST ---
(In reply to comment #15)
> Created an attachment (id=81517)
 --> (https://bugs.webkit.org/attachment.cgi?id=81517&action=review) [details]
> Patch for Chromium on Mac, v2
> 
> Re directionalOverride, agreed; changed.
> 
> Re textDirection. This is of enum type, which IMO makes it clear. platform/PopupMenuStyle.h has textDirection() returning the same enum. "Direction" always means LTR/RTL when it comes to text. See editing/WritingDirection.h, editing/EditingStyle.h's textDirection(), WK/chromium/public/WebTextDirection.h, etc.

Can you use WebTextDirectionDefault in place of hasTextDirectionOverride?  

Unlike WebCore::TextDirection, WebTextDirection has the "unspecified" state.  It seems like hasTextDirectionOverride is therefore unnecessary / redundant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.