[Webkit-unassigned] [Bug 51760] Changeset #67245 was incompletely implemented

Wed Feb 9 13:21:40 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=51760

--- Comment #13 from James Simonsen <simonjam at chromium.org>  2011-02-09 13:21:40 PST ---
(In reply to comment #11)
> > Since the beforeload event isn't standardized, the spec doesn't have anything to say about this. But as this is placed, we would still fire a beforeload event when we aren't actually planning to load the script.
> 
> Maybe we should do this check twice?  Once before the event and then again afterwards?  Definitely should be tested.

I implemented it this way and added test cases for all the combinations.

There's a FIXME in there to reduce some redundancy. The best way to address it would be to rewrite more of ScriptElement to match the HTML5 spec. I'll get to that later with a separate issue & patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.