[Webkit-unassigned] [Bug 53071] [NRWT] Pull up a rebaseline feature into a single_test_runner out of each test_type.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 13:20:55 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53071





--- Comment #9 from Dirk Pranke <dpranke at chromium.org>  2011-02-09 13:20:55 PST ---
(In reply to comment #7)
> Thank you for the review.
> I've merged the patch with ToT and am going to commit it manually.
> 
> (In reply to comment #6)
> > Is this covered by existing unit tests?  If not, it would be nice to add some (either in this patch or a follow up patch).
> 
> There is no existing unit tests for rebaseline.
> It seems that we've started to use abstract file system modules recently, now it is possible to write unit tests for rebaseline. That will be in a follow up patch.
> 

There are tests in run_webkit_tests_unittest  - see the RebaselineTest class. So, I would expect these changes to have been covered by the existing tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list