[Webkit-unassigned] [Bug 52699] Allow Fixed Length values to be floating point

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 13:20:48 PST 2011


--- Comment #6 from Rik Cabanier <cabanier at gmail.com>  2011-02-09 13:20:48 PST ---
> > 
> > That doesn't work today either. Length can store at most 134217472 which is less than 999999999. The class also doesn't do bounds checking, so the larger value will overflow and become garbage.
> Bounds checking should happen elsewhere (e.g. in CSSPrimitiveValue methods).
I'll check there too...
> > It seems that making it a full int or float is the correct solution. Is it acceptable that the class takes up 4 more bytes?
> I don't know; we pass Lengths by value all over the place.

I wasn't thinking of stack space. Is that a concern?
It was more about heap space if a lot of length objects are stored.

I've reimplemented my changes and the browser seems to render content fine, but I can't get a clean layout test. I reverted all my changes and tests are still failing.

Do I need to do more than sync everything and get the fonts?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list