[Webkit-unassigned] [Bug 54117] Replace static_cast<HTMLElement*> with toHTMLElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 12:24:12 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54117


Yael <yael.aharon at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81829|0                           |1
        is obsolete|                            |
  Attachment #81851|                            |review?, commit-queue?
               Flag|                            |




--- Comment #4 from Yael <yael.aharon at nokia.com>  2011-02-09 12:24:12 PST ---
Created an attachment (id=81851)
 --> (https://bugs.webkit.org/attachment.cgi?id=81851&action=review)
Patch.

Only one test hit the ASSERT. It is editing/execCommand/insert-list-nested-with-orphaned.html .
This test is really expecting the function enclosingListChild to return a node which is not an HTMLElement.
(The test fails if I skip nodes that are not HTMLElements.)
Once I modified enclosingListChild to return Node and not HTMLElement, all tests are passing. I updated the patch to  return a Node from enclosingListChild.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list