[Webkit-unassigned] [Bug 54118] XMLHttpRequest::abort() should call clearResponse()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54118


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81834|review?                     |review+
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2011-02-09 10:49:31 PST ---
(From update of attachment 81834)
View in context: https://bugs.webkit.org/attachment.cgi?id=81834&action=review

> Source/WebCore/ChangeLog:16
> +        abort() is not properly clearing ArrayBuffer binary buffered data. This
> +        change will remove the cleanup code from abort() and instead call
> +        clearResponse() to do the cleanup, which not only does the original abort()
> +        cleanup, but also covers the binary response buffer as well. Future cleanup
> +        omissions can be avoided by only having to maintain clearResponse().
> +        
> +        Clearing the data on abort() is more memory efficient.  By not clearing
> +        this data, it will remain in memory until the XHR object is cleaned up or
> +        until a subsequent call to open().

This comment is too long. It would be better to say something like this:

    Calling clearResponse frees more memory at abort time.

    No new tests because there is no observable effect except for less memory used.

The longer paragraph is something people probably won’t read.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.