[Webkit-unassigned] [Bug 54118] XMLHttpRequest::abort() should call clearResponse()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54118


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81831|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-02-09 10:30:42 PST ---
(From update of attachment 81831)
View in context: https://bugs.webkit.org/attachment.cgi?id=81831&action=review

> Source/WebCore/ChangeLog:6
> +        XMLHttpRequest::abort() should call clearResponse()
> +        https://bugs.webkit.org/show_bug.cgi?id=54118

This change log entry is not sufficient. It doesn’t state why this is a good change. As you do in your bug, but more briefly, you need to state the benefit of the change: Less memory used after an abort(), presumably.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

We can’t land a patch with a line like this. You need to change this line into an explanation of why it’s OK to make this change without adding any new tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.