[Webkit-unassigned] [Bug 31742] [Qt] QWebView ignores a palette set with QWebView::setPalette()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31742


Benjamin Poulain <benjamin.poulain at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81390|review?                     |review-
               Flag|                            |




--- Comment #22 from Benjamin Poulain <benjamin.poulain at nokia.com>  2011-02-09 10:01:06 PST ---
(From update of attachment 81390)
View in context: https://bugs.webkit.org/attachment.cgi?id=81390&action=review

The test needs some rework to make it simpler and test one feature at the time.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1435
>  {
> -    return  QApplication::cursorFlashTime() / 1000.0 / 2.0;
> +    return QApplication::cursorFlashTime() / 1000.0 / 2.0;
>  }

This is unrelated. You should a separate patch for this.

> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34
> -{
> +class tst_QWebView : public QObject {

You should fix the style in a separate patch.

> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:325
> +    // Test 1:  BEGIN:  Selection background color on active QWebView   

You should split the test in multiple, simpler functions. Each testing one aspect of the patch.

> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:349
> +    QString strActiveRedBg="activeRedBg.png";
> +    imgActiveRedBg.save(strActiveRedBg);

Why do you save the image in a test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.