[Webkit-unassigned] [Bug 51760] Changeset #67245 was incompletely implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51760





--- Comment #10 from Tony Gentilcore <tonyg at chromium.org>  2011-02-09 08:59:24 PST ---
(From update of attachment 81746)
View in context: https://bugs.webkit.org/attachment.cgi?id=81746&action=review

> Source/WebCore/dom/ScriptElement.cpp:160
> +    if (!shouldExecuteAsJavaScript())

Since the beforeload event isn't standardized, the spec doesn't have anything to say about this. But as this is placed, we would still fire a beforeload event when we aren't actually planning to load the script.

My first thought is that this check should be performed before the beforeload is fired. But OTOH, the beforeload event could also change attributes which affect the result of this check, so I can see an argument for after beforeload as well. Maybe check how parser inserted scripts behave and do the same? In any case, I'd recommend adding a test since this behavior is subtle.

Everything else lgtm.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.