[Webkit-unassigned] [Bug 54028] http/tests/media should be served over HTTP (not from local file)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54028





--- Comment #10 from Eric Carlson <eric.carlson at apple.com>  2011-02-09 05:59:59 PST ---
(In reply to comment #9)
> Hmm, I was always assuming that there was a very good reason to run these tests from local files. I guess not.
> 
> Did you check which revision this behavior was introduced in, and how it was explained?

It was this way from when Antti added support for http media tests in r27757:

Index: Tools/Scripts/run-webkit-tests
===================================================================
--- Tools/Scripts/run-webkit-tests    (revision 27584)
+++ Tools/Scripts/run-webkit-tests    (revision 27757)
@@ -314,6 +314,7 @@

 if (!$testMedia) {
     $ignoredDirectories{'media'} = 1;
+    $ignoredDirectories{'http/tests/media'} = 1;
 }

 if ($ignoreTests) {
@@ -484,7 +485,7 @@
         print OUT "$testPath\n";
     } else {
         openHTTPDIfNeeded();
-        if ($test !~ /^http\/tests\/local\// && $test !~ /^http\/tests\/ssl\//) {
+        if ($test !~ /^http\/tests\/local\// && $test !~ /^http\/tests\/ssl\// && $test !~ /^http\/tests\/media\//) {
             my $path = canonpath($test);
             $path =~ s/^http\/tests\///;
             print OUT "http://127.0.0.1:$httpdPort/$path\n";

He doesn't remember why it was done that way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.