[Webkit-unassigned] [Bug 48509] [GTK] Implement WebView and WebKitWebView classes for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48509





--- Comment #24 from Xan Lopez <xan.lopez at gmail.com>  2011-02-09 02:48:51 PST ---
(In reply to comment #22)
> (From update of attachment 78945 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78945&action=review
> 
> > WebKit2/UIProcess/gtk/WebView.cpp:73
> > +    GtkWidget* toplevel = gtk_widget_get_toplevel(widget);
> > +    if (GTK_WIDGET_TOPLEVEL(toplevel) && gtk_window_has_toplevel_focus(GTK_WINDOW(toplevel))) {
> 
> Is it really necessary to check GTK_WIDGET_TOPLEVEL(...) on the return value of gtk_widget_get_toplevel(...)?
> 

It is recommended, yes, check the documentation of the function.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.