[Webkit-unassigned] [Bug 53071] [NRWT] Pull up a rebaseline feature into a single_test_runner out of each test_type.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53071





--- Comment #7 from Hayato Ito <hayato at chromium.org>  2011-02-08 21:29:25 PST ---
Thank you for the review.
I've merged the patch with ToT and am going to commit it manually.

(In reply to comment #6)
> (From update of attachment 81606 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81606&action=review
> 
> > Tools/ChangeLog:10
> > +        This patch is a first step for eliminating test_type/* classes.
> > +
> > +        https://bugs.webkit.org/show_bug.cgi?id=53071
> 
> Is this covered by existing unit tests?  If not, it would be nice to add some (either in this patch or a follow up patch).

There is no existing unit tests for rebaseline.
It seems that we've started to use abstract file system modules recently, now it is possible to write unit tests for rebaseline. That will be in a follow up patch.

> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:111
> > +            self._save_baseline_data(driver_output.image_hash, ".checksum",
> > +                                     encoding="ascii",
> > +                                     generate_new_baseline=self._options.new_baseline)
> 
> In a separate patch, we could just get rid of the encoding flag.  If we encode the .checksum files as binary, it should be the same as ascii.

Thank you. I'll take care of it in a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.