[Webkit-unassigned] [Bug 52699] Allow Fixed Length values to be floating point

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52699


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81737|                            |review-
               Flag|                            |




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-02-08 20:53:49 PST ---
(From update of attachment 81737)
View in context: https://bugs.webkit.org/attachment.cgi?id=81737&action=review

> Source/WebCore/ChangeLog:7
> +        No new tests. However, this fix can introduce differences in existing tests since it can make a small difference in layout

In that case the patch needs to include new results for all the affected tests.

This changelog entry needs to mention the changes in Length behavior.

> Source/WebCore/platform/Length.h:33
> -const int percentScaleFactor = 128;
> -const int intMaxForLength = 0x7ffffff; // max value for a 28-bit int
> -const int intMinForLength = (-0x7ffffff - 1); // min value for a 28-bit int
> +const int intMaxForLength = 0x7ffff; // max value for a 20-bit int
> +const int intMinForLength = (-0x7ffff - 1); // min value for a 20-bit int

I don't think it's acceptable to change the max and min int values that Length can store. That might break websites (which do things like z-index: 999999999).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.