[Webkit-unassigned] [Bug 52128] ISO-8859-8 Hebrew text displayed reversed with dir="rtl"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52128


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80800|0                           |1
        is obsolete|                            |
  Attachment #81727|                            |review?
               Flag|                            |




--- Comment #16 from Xiaomei Ji <xji at chromium.org>  2011-02-08 18:15:09 PST ---
Created an attachment (id=81727)
 --> (https://bugs.webkit.org/attachment.cgi?id=81727&action=review)
patch w/ layout test

Thanks for the review!
Updated patch per feedback.

The 2nd part of the diff (about reordering runs) inside void BidiResolver<Iterator, Run>::createBidiRunsForLine() is format change (decrease indent) due to the removal of condition "if (!visualOrder)".

I tested the bidi resolver part for lines with visual ordering using
https://service.isracard.co.il/templates/isracardEntry/contactus.jsp and http://berry.co.il/disco/chalordeluna/playme.php
they works correctly.

Dan, Jeremy, if you have more real webpage that uses iso-8859-8, please pass them to me for test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.