[Webkit-unassigned] [Bug 50762] [EFL] ContextMenu implementation is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50762





--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-02-08 16:47:08 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > After some code changes last year, it's broken again :(. I think the EFL builders are green because they are not cleaning the tree between builds.
> > > 
> > > Gyuyoung Kim: are you compiling the latest svn revision?
> > 
> > Yes, in my linux box, there is no build breaks in latest svn revision. I remember leandro fixed this build break without review. Do you have build break due to the context menu ?
> 
> Yes. See below:
> 
> Linking CXX shared library libwebcore_efl.so
> CMakeFiles/webcore_efl.dir/platform/efl/ContextMenuEfl.cpp.o: In function `WebCore::ContextMenu::ContextMenu()':
> ContextMenuEfl.cpp:(.text+0x0): multiple definition of `WebCore::ContextMenu::ContextMenu()'
> CMakeFiles/webcore_efl.dir/platform/ContextMenu.cpp.o:ContextMenu.cpp:(.text+0x560): first defined here
> CMakeFiles/webcore_efl.dir/platform/efl/ContextMenuEfl.cpp.o: In function `WebCore::ContextMenu::ContextMenu()':
> ContextMenuEfl.cpp:(.text+0x0): multiple definition of `WebCore::ContextMenu::ContextMenu()'
> CMakeFiles/webcore_efl.dir/platform/ContextMenu.cpp.o:ContextMenu.cpp:(.text+0x560): first defined here
> CMakeFiles/webcore_efl.dir/platform/efl/ContextMenuItemEfl.cpp.o: In function `WebCore::ContextMenuItem::ContextMenuItem(WebCore::ContextMenuItemType, WebCore::ContextMenuAction, WTF::String const&, WebCore::ContextMenu*)':
> ...
> 
> I've just noticed this will only occur when configuring with SHARED_CORE=ON. This is how I'm configure webkit:
> 
> cmake ../Source -DPORT=Efl \
>     -DCMAKE_INSTALL_PREFIX=$HOME/dev/e/ \
>     -DENABLE_JIT=ON \
>     -DSHARED_CORE=ON \
>     -DNETWORK_BACKEND=curl \
>     -DENABLE_GLIB_SUPPORT=ON \
>     -DENABLE_VIDEO=ON \
>     -DENABLE_PROGRESS_TAG=ON
> 
> Can you reproduce?

Yes, I can reproduce this build break. However, when I build with this simple command "cmake ../Source -DPORT=Efl", there are no build breaks. 
 It seems the build configuration makes problems.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.