[Webkit-unassigned] [Bug 53716] JSC::Bindings m_rootObject->isValid() assert fails when running layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53716


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81683|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2011-02-08 13:38:33 PST ---
(From update of attachment 81683)
View in context: https://bugs.webkit.org/attachment.cgi?id=81683&action=review

review+ but I would like the patch better if it didn’t do the same thing twice.

> Source/WebCore/bridge/jsc/BridgeJSC.cpp:110
> -    ASSERT(m_rootObject->isValid());
> -    m_rootObject->removeRuntimeObject(object);
> +    if (m_rootObject->isValid())
> +        m_rootObject->removeRuntimeObject(object);

Good to remove the assertion, but why check isValid here since you already added the check to removeRuntimeObject?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.