[Webkit-unassigned] [Bug 6503] content property doesn't support quotes

Tue Feb 8 12:54:58 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=6503

--- Comment #23 from Dave Hyatt <hyatt at apple.com>  2011-02-08 12:54:58 PST ---
(From update of attachment 81638)
View in context: https://bugs.webkit.org/attachment.cgi?id=81638&action=review

> Source/WebCore/rendering/style/StyleRareInheritedData.h:91
> +    Vector<String> quotes;

Basically I'd consider turning the Vector into a pointer and only allocate it when there are concrete quotes specified explicitly in CSS.  Then you could add a member like bool m_useUAQuotes; and have that be set to true for the initial value (and false when quotes is explicitly set, either to none or to a concrete value).

Vector<String>* m_authorQuotes;
bool m_useUAQuotes;

Then you just need a good place to resolve to a real value if m_useUAQuotes is set instead of having a Vector.  It seems like you could do that in placeQuote and have a global hashmap in RenderQuote that just stores the different languages.  For the first landing you can just make a static Vector sitting right in placeQuote for English and use that if the user agent value is set.

You still need to patch CSSComputedStyleDeclaration as well, although doing that in a follow-up patch would be fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.