[Webkit-unassigned] [Bug 53953] ImageDecoderSkia doesn't notify Skia's bitmap when the pixels have changed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53953





--- Comment #7 from Peter Kasting <pkasting at google.com>  2011-02-08 11:22:01 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > How often do you need to notify the backend?
> 
> Well, the main one is to be called after the entire image has loaded to make sure that we don't get stuck in a half-loaded state where Skia just keeps a half-downloaded image on the screen and never updates it.

If that's all you need, this probably works.  It does seem a bit confusing though as setStatus() doesn't necessarily imply anything about the immediate pixel state, so a "notify pixels changed" call feels wrong semantically.

A better fix might be to instead make this call inside NativeImageSkia::setDataComplete().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.