[Webkit-unassigned] [Bug 52791] Buffer overrun in WebCore::InspectorBasicValue::writeJSON

Tue Feb 8 07:53:07 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=52791

--- Comment #25 from Pavel Feldman <pfeldman at chromium.org>  2011-02-08 07:53:07 PST ---
> Maybe it has been removed, but I hope not.

I am sure I did remove it couple of weeks ago.

> I just found no place in the frontend that would be suitable to hang in.

Could you elaborate on "sutable to hang in"?

> Creating a view with JS debugging set and with my new inspector client. This client then receives messages (by getting a function called with a command given by string) and sends responses by calling a callback function. Inside it translates this communication to a communication based on the inspector protocol.

This sounds close to the right way of doing it, but it is not clear whether you are using inspector front-end or any different one.

> > > I understand that this is maybe not the best way to implement it, but we haven't found any better one. I have opened another bug for discussing it counting for that I will get some help about a best way to do it, but I got no valuable response.

I would not want to make InspectorValue private and a friend of inspector internals that need it. Same is true about the rest of the WebCore/inspector internals. The only public class that should be used is InspectorController. It will have a bare API for showing and closing inspector soonish. Would not want you to depend on the things we consider private and are about to hide. You should align with us early.

> > 
> > Could you link to it from here?
> 
> Not yet, sorry. But as long as we finish our work, the patch with the whole code will be submitted.

I was asking could you link to "bug for discussion" from here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.