[Webkit-unassigned] [Bug 53916] [Qt] WebKit patches required to work with a modularized version of Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 00:08:30 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53916





--- Comment #10 from Kristian Amlie <kristian.amlie at nokia.com>  2011-02-08 00:08:30 PST ---
> Do all of that work with and without modularization?

I tested with both versions, so they should work. We will probably need a couple of more patches down the line though, but this is a start.

> One patch per bug is generally preferred.

Ok. I didn't know about the one-patch-per-bug policy. Is it ok to go forward with this one, and I will remember it for next time?

> You'll need to remove thsi line (generally replacing it with explaination of testing or why testing is impossible.  In this case you can just write something like "build fix, no tests.")

Right. I guess I trusted the prepare-Changelog script too blindly. I'll fix it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list