[Webkit-unassigned] [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow.

Mon Feb 7 21:13:56 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=50661

Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81576|review?                     |review-
               Flag|                            |

--- Comment #3 from Kent Tamura <tkent at chromium.org>  2011-02-07 21:13:56 PST ---
(From update of attachment 81576)
View in context: https://bugs.webkit.org/attachment.cgi?id=81576&action=review

Some drive-by comments.

> Source/WebCore/ChangeLog:22
> +        Need a short description and bug URL (OOPS!)

oops!

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22454
> +				0F3DD45012F5EA1B000D9190 /* ShadowBlur.h in Headers */,
> +				BCE4413412F748E2009B84B8 /* RenderCombineText.h in Headers */,
> +				BCE4413612F7490B009B84B8 /* FontWidthVariant.h in Headers */,
> +				14947FFE12F80CD200A0F631 /* DocumentOrderedMap.h in Headers */,
> +				97C471DC12F925BD0086354B /* ContentSecurityPolicy.h in Headers */,
> +				A7FE819C12FA677700850C1E /* ProgressBarValueElement.h in Headers */,

Do you want to add these files?

> Source/WebCore/html/shadow/MeterPartElement.h:53
> +    MeterPartElement(Document* document, PartType type) 

This should be private.

> Source/WebCore/html/shadow/MeterPartElement.h:76
> +inline const AtomicString* MeterPartElement::computeShadowPseudoId()

Do not define such large functions in a header file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.