[Webkit-unassigned] [Bug 53897] [chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53897


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81561|review?                     |review-
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2011-02-07 18:22:28 PST ---
(From update of attachment 81561)
View in context: https://bugs.webkit.org/attachment.cgi?id=81561&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1963
> -WebFrameImpl* WebFrameImpl::fromFrameOwnerElement(Element* element)
> +WebFrameImpl* WebFrameImpl::fromFrameOwnerElement(const Element* element)

Why is this change related to the problem you're trying to solve?  We almost never have "const Element*".

> Source/WebKit/chromium/src/WebPageSerializerImpl.cpp:331
> +                        String completeURL = subFrame ? KURL(subFrame->url()) : param->document->completeURL(attrValue);

Why do we need to call KURL if we're trying to get a String in the end?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.