[Webkit-unassigned] [Bug 53942] [Chromium] Select popup box does not align with select button when appearance is not "menulist".

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53942





--- Comment #5 from xiyuan <xiyuan at chromium.org>  2011-02-07 16:36:01 PST ---
(From update of attachment 81525)
View in context: https://bugs.webkit.org/attachment.cgi?id=81525&action=review

>> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1272

> 
> static?  Also, should this be at the top of the file with the other constants?  The other constants are named incorrectly (k prefix), but we can fix that later.

Done.

>> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1275

> 
> Nit: rightAligned -> isRightAligned

Done

>> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1349
>> +        // Use minEndOfLinePadding when there is a scrollbar.
> 
> Why does a scrollbar cause us to need 2 extra pixels?

Updated the comment to make it more clear.

It's not that we need the 2 extra pixels. We replace the lineEndPaddingWidth space with the minimum 2 pixel space when there is a scrollbar. In this way, scrollbar will stay as much as possible inside the line end padding space. User could use a big enough "padding-right" (>= scrollbarWidth + 2px) to make the popup listbox align with the select button.

This is because https://bugs.webkit.org/show_bug.cgi?id=33235 makes popup respect the "padding-right". It works well when there is no scrollbar. But when popup has a scrollbar, the popup is always wider than the select button no matter what padding-right value you use. You can see that from the test case page.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.