[Webkit-unassigned] [Bug 53942] [Chromium] Select popup box does not align with select button when appearance is not "menulist".

Mon Feb 7 16:06:54 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=53942

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81525|review?                     |review-
               Flag|                            |

--- Comment #3 from Tony Chang <tony at chromium.org>  2011-02-07 16:06:54 PST ---
(From update of attachment 81525)
View in context: https://bugs.webkit.org/attachment.cgi?id=81525&action=review

just some small nits

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1272
> +const int minEndOfLinePadding = 2;

static?  Also, should this be at the top of the file with the other constants?  The other constants are named incorrectly (k prefix), but we can fix that later.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1275
> +    bool rightAligned = m_popupClient->menuStyle().textDirection() == RTL;

Nit: rightAligned -> isRightAligned

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.