[Webkit-unassigned] [Bug 53906] [EFL] Add dummy functions for HTML5 Video's control UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53906





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-02-07 15:50:49 PST ---
(In reply to comment #2)
> (From update of attachment 81453 [details])
> OK.  So currently the compile fails if you enable VIDEO w/o these?  Or does it just use the defaults?  if it uses the default implementations then it seems these are implemented incorrectly (and should instead call the parent function.

In WebKit EFL, VIDEO feature is enabled by default. So, these functions will be used by default. 


Currently, these functions which paint players's control UI are defined in RenderTheme.h file virtually.

283     virtual bool paintMediaFullscreenButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
284     virtual bool paintMediaPlayButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
285     virtual bool paintMediaMuteButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
286     virtual bool paintMediaSeekBackButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
287     virtual bool paintMediaSeekForwardButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
288     virtual bool paintMediaSliderTrack(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
289     virtual bool paintMediaSliderThumb(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
290     virtual bool paintMediaVolumeSliderContainer(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
291     virtual bool paintMediaVolumeSliderTrack(RenderObject*, const 
...

Now, the parent functions just return "true" because WebKit EFL doesn't implement these functions yet. So, first of all, I add dummy functions, then I'd like to implement these functions step by step. If I have misunderstanding, please let me know. Thank you. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.