[Webkit-unassigned] [Bug 53811] Null deref in DOMURL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53811


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81304|review?                     |review-
               Flag|                            |




--- Comment #2 from Jian Li <jianli at chromium.org>  2011-02-07 15:42:46 PST ---
(From update of attachment 81304)
View in context: https://bugs.webkit.org/attachment.cgi?id=81304&action=review

> Source/WebCore/ChangeLog:5
> +        fix null deref in DOMURL

Please capitalize the 1st character.

> LayoutTests/ChangeLog:9
> +        * fast/dom/domurl-script-execution-context-crash.html: Added.

Since DOMURL is only used for blob URL, I think we'd better put this new test under fast/files.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:6
> +        e.apply(w,['webkitURL']);

Please add a space after comma.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:16
> +    setTimeout(crash,30);

ditto.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:26
> +e=(w=open()).eval;

Please add space before and after 2 "=" operators.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.