[Webkit-unassigned] [Bug 53951] drawImageBuffer in GraphicsContext passes magic (-1, -1) sized rects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 15:29:39 PST 2011


--- Comment #6 from Darin Adler <darin at apple.com>  2011-02-07 15:29:39 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Does this change have any effect? How can we test that the fix is effective? Normally we do not accept code changes that fix bugs without regression tests.
> It's exactly the same logic as is applied in drawImage. This is clearly what the original author of drawImageBuffer intended [...]
> This fixes rendering issues with certain versions of Skia.

For the record, the requirement for a regression test is not any reflection on how good or obvious a fix is, or how silly the original error was.

I think it’s OK for us to take this change that has no effect with any current configurations and is useful to Google in your work with newer fancier versions of Skia. But in the future, change log should explain why there is no test when you propose a change without a test.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list