[Webkit-unassigned] [Bug 53857] [Chromium] Layout Test canvas/philip/tests/2d.composite.globalAlpha.fill.html with --accelerated-2d-canvas.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53857


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81369|review?                     |review-
               Flag|                            |




--- Comment #3 from Kenneth Russell <kbr at google.com>  2011-02-07 15:21:33 PST ---
(From update of attachment 81369)
View in context: https://bugs.webkit.org/attachment.cgi?id=81369&action=review

> Source/WebCore/platform/graphics/chromium/GLES2Canvas.cpp:103
> +#if PLATFORM(SKIA)
> +        int a = SkAlphaMul(c.alpha(), s);
> +#else
> +        int a = (c.alpha() * s) >> 8;
> +#endif

The Skia-specific code path is not really necessary here. I'd just remove it.

> Source/WebCore/platform/graphics/chromium/GLES2Canvas.cpp:104
> +        return Color((c.rgb() & 0x00FFFFFF) | (a << 24));

I think you should avoid relying on Color's internal representation. You could write this portably as

return Color(c.red(), c.green(), c.blue(), a);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.