[Webkit-unassigned] [Bug 53951] drawImageBuffer in GraphicsContext passes magic (-1, -1) sized rects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53951





--- Comment #3 from George Wright <gwright at kde.org>  2011-02-07 15:20:30 PST ---
(In reply to comment #2)
> (From update of attachment 81536 [details])
> Does this change have any effect? How can we test that the fix is effective? Normally we do not accept code changes that fix bugs without regression tests.

It's exactly the same logic as is applied in drawImage. This is clearly what the original author of drawImageBuffer intended, but forgot to set up the FloatRects accordingly (evident by the fact that drawImageBuffer already calculates th, tw, tsh and tsw but never actually uses them).

This fixes rendering issues with certain versions of Skia.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.