[Webkit-unassigned] [Bug 36840] SVG @font-face breaks text-overflow: ellipsis

Mon Feb 7 11:27:30 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=36840

Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80598|review?                     |review-
               Flag|                            |

--- Comment #12 from Dirk Schulze <krit at webkit.org>  2011-02-07 11:27:30 PST ---
(From update of attachment 80598)
View in context: https://bugs.webkit.org/attachment.cgi?id=80598&action=review

Nearly done:

> Source/WebCore/ChangeLog:18
> +        Implement offsetForPositionForTextUsingSVGFont for SVG fonts, fixing
> +        rendering of SVG font-styled text with text-overflow: ellipsis and
> +        per-character selection of SVG font-styled text.  Uses existing
> +        SVGTextRunWalker mechanism to walk the text run, measuring total pixel
> +        length up to the specified limit, then returning the number of characters
> +        walked.
> +
> +        SVG @font-face breaks text-overflow: ellipsis
> +        https://bugs.webkit.org/show_bug.cgi?id=36840
> +        REGRESSION: SVG Font selection problems
> +        https://bugs.webkit.org/show_bug.cgi?id=41934
> +
> +        Tests: editing/selection/select-text-svgfont.html
> +               fast/css/text-overflow-ellipsis-svgfont.html

Please use this style:

bug name
bug link

bug name
bug link

comment

Tests:

> Source/WebCore/svg/SVGFont.cpp:609
> +    return (data.at < data.to && data.length <= data.maxLength);

No braces here

> Source/WebCore/svg/SVGFont.cpp:640
> +    int len = run.length();

name it length

> Source/WebCore/svg/SVGFont.cpp:658
> +    if (!(includePartialGlyphs && (data.maxLength > data.length - (data.lastGlyphLength / 2))))

if (!includePartialGlyphs || !(data.maxLength > data.length - (data.lastGlyphLength / 2)))

two braces less

> LayoutTests/fast/css/text-overflow-ellipsis-svgfont.html:1
> +<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="TEXT/HTML; CHARSET=utf8">

<!DOCTYPE html>
<html>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.