[Webkit-unassigned] [Bug 53919] New: Reference-counting for WKBundlePageLoaderClient::willSendRequestForFrame seems unclear/wrong

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53919

           Summary: Reference-counting for
                    WKBundlePageLoaderClient::willSendRequestForFrame
                    seems unclear/wrong
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
               URL: http://trac.webkit.org/browser/trunk/Source/WebKit2/We
                    bProcess/InjectedBundle/InjectedBundlePageLoaderClient
                    .cpp?rev=77713#L184
        OS/Version: All
            Status: NEW
          Keywords: NeedsRadar
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: mjs at apple.com, sullivan at apple.com, sam at webkit.org,
                    bweinstein at apple.com


InjectedBundlePageLoaderClient::willSendRequestForFrame, which calls WKBundlePageLoaderClient::willSendRequestForFrame (see URL), refs the result. This implies that willSendRequestForFrame should return a WKURLRequestRef whose refcount hasn't been incremented. But that makes returning a newly-constructed WKURLRequestRef very hard to do without causing a leak, since it requires the client to release the WKURLRequestRef *after* returning it from willSendRequestForFrame.

Probably the best way to fix this is to give willSendRequestForFrame Create semantics, just like WKPageUIClient::createPage. InjectedBundlePageLoaderClient::willSendRequestForFrame should adopt the WKURLRequestRef instead of reffing it. We may want to rename willSendRequestForFrame if we do this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.