[Webkit-unassigned] [Bug 53642] pop-up button text not rendered correctly according to its direction in <option>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53642





--- Comment #5 from mitz at webkit.org  2011-02-06 23:46:11 PST ---
(In reply to comment #3)
> Created an attachment (id=81017)
 --> (https://bugs.webkit.org/attachment.cgi?id=81017&action=review) [details]
> patch
> 
> Thanks for the quick review and feedback!
> Update patch per suggestion.
> 
> And I have 2 questions:
> 1. what is the difference between m_innerBlock's style and m_buttonText's style?  They are setting different values in the code. when m_button's style takes effect?

Hm… that’s a good question. I can see how the styles could get out of sync, which might actually be a problem for direction and unicode-bidi since some code probably looks at the RenderText’s style directly.

> 2. anyway to do automatic test? I am in the process of implementing the same for chromium port and found out another regression on a <select> related manual test I added.

Would something like

var selectElement = document.getElementById("…");
document.body.offsetTop; // Force layout
selectElement.selectedIndex = 1;

work? You could even use multiple select elements, each with a different combination of initial and final selected index and do the whole thing in one test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.