[Webkit-unassigned] [Bug 51013] [Chromium] Should implement EditorClientImpl::requestCheckingOfString()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51013





--- Comment #31 from MORITA Hajime <morrita at google.com>  2011-02-06 20:44:30 PST ---
Darin, thanks for your review again.
I addressed the points.

> (From update of attachment 81182 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81182&action=review
> 
> > Source/WebKit/chromium/public/WebTextCheckingCompletion.h:35
> > +#include "WebTextCheckingResult.h"
> 
> nit: i think you can just forward declare WebTextCheckingResult and WebVector here instead.
Sure. Fixed.

> 
> > Source/WebKit/chromium/public/WebTextCheckingResult.h:35
> > +#include "WebVector.h"
> 
> nit: no need for WebVector include here
Done.

> 
> > Tools/DumpRenderTree/chromium/WebViewHost.cpp:232
> > +    WebViewHost* wvh = static_cast<WebViewHost*>(context);
> 
> how do you know that the WebViewHost hasn't been deleted by the time this function is called?
No.
I found there are some other place use similar trick in WebViewHost.
So I filed Bug 53899 to address them separately.
My plan is to track live WebViewHost instances and verify passed one's liveness before using it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.