[Webkit-unassigned] [Bug 45889] Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45889





--- Comment #24 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-06 13:45:54 PST ---
(In reply to comment #23)
> (From update of attachment 80639 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=80639&action=review
> The actual issue is, When you click on text field==>enter text=> delete complete text==>Now, I cannot enter text as i am not able to edit the focusing node==> Even i cannot gain the cursor by clicking on the text field==> Now if i click outside the textfield with mouse and click on text field again, i Can enter the text. So the issue is that, till the focus is on text field and while editing the text only. When the focus is lost and gain back, There is no issue. I have attached the issue test page (45889_issue.htm). Kindly try to reproduce the issue. Do let me know your comment.

I know what the problem you're trying to solve.  However, my point is that you're only fixing the very special case and not taking care of others.  Namely, we're still inserting BR into non-focused text field and that's just wrong.  We should never be inserting BR into text field.  So your condition for inserting BR should be that it's not inside a multi-line shadow DOM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.