[Webkit-unassigned] [Bug 53880] Use bloom filter for descendant selector filtering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53880





--- Comment #8 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-02-06 12:12:01 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 81416 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=81416&action=review
> > 
> > r=me with one minor comment
> > 
> > > Source/JavaScriptCore/wtf/BloomFilter.h:77
> > > +    char m_table[tableSize];
> > 
> > I'd suggest using "unsigned char" or uint8_t for this, since it's using char as a byte, not a character, and this avoids pain on platforms where char is signed by default.
> 
> Pls don't land as is -- breaks Chromium.

Nevermind -- haven't seen the second patch :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.