[Webkit-unassigned] [Bug 53880] Use bloom filter for descendant selector filtering

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 6 12:07:30 PST 2011


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
  Attachment #81416|review?                     |review+
               Flag|                            |

--- Comment #6 from Maciej Stachowiak <mjs at apple.com>  2011-02-06 12:07:30 PST ---
(From update of attachment 81416)
View in context: https://bugs.webkit.org/attachment.cgi?id=81416&action=review

r=me with one minor comment

> Source/JavaScriptCore/wtf/BloomFilter.h:77
> +    char m_table[tableSize];

I'd suggest using "unsigned char" or uint8_t for this, since it's using char as a byte, not a character, and this avoids pain on platforms where char is signed by default.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list