[Webkit-unassigned] [Bug 50916] Add support for dir=auto

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 6 01:26:40 PST 2011


--- Comment #22 from Jeremy Moskovich <playmobil at google.com>  2011-02-06 01:26:40 PST ---
(In reply to comment #19)
> (In reply to comment #17)
> Thanks for your comments,
> > (From update of attachment 80968 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=80968&action=review
> > > Source/WebCore/html/HTMLElement.cpp:868
> > > +    ASSERT(equalIgnoringCase(fastGetAttribute(dirAttr), "auto"));
> > 
> > It's only legal to call this method on an element which has dir=auto set?
> > Could you add a comment on why that is?
> > 
> I am not sure what is the use for calling this function unless the element has the attribute dir="auto" ?

My thinking is that to someone reading this code without the context of this bug, the reason for the assert isn't clear.  If you could add a comment as to why or change the name of the function [e.g. resolveDirectionality()] it may be easier to understand this.

The point I find confusing is that it looks like this is the canonical way to get the directionality of an HTMLElement, whereas it's only useful for dir=auto.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list