[Webkit-unassigned] [Bug 50916] Add support for dir=auto

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 5 15:04:58 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=50916


Yael <yael.aharon at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #80968|0                           |1
        is obsolete|                            |
  Attachment #80968|review?                     |
               Flag|                            |
  Attachment #81377|                            |review?
               Flag|                            |




--- Comment #20 from Yael <yael.aharon at nokia.com>  2011-02-05 15:04:58 PST ---
Created an attachment (id=81377)
 --> (https://bugs.webkit.org/attachment.cgi?id=81377&action=review)
Patch.

When an element has dir attribute with value "auto", call defaultWritingMode to find its directionality.
Added a flag SelfOrAncestorHasDirAutoFlag, and added hooks in the DOM to set and check this flag. This flag is set on every node between an element with dir=auto attribute and its first text node. Changes in the DOM between those elements will trigger re-evaluating the directionality, but changed not between those element do not need to be concerned.
The DOM hooks were added to childrenChanged, and to parseMappedAttribute. The directionality is evaluated when children are added, but not when they are removed. Once they are re-added, the directionality will be evaluated.

Added 2 static CSSMutableStyleDeclarations to be used for elements with dir=auto.
We cannot use the mapped declaration, because it can take only one value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list