[Webkit-unassigned] [Bug 50237] [Gtk] Implement layoutTestController.findString

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50237





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-02-05 10:38:23 PST ---
(From update of attachment 81345)
View in context: https://bugs.webkit.org/attachment.cgi?id=81345&action=review

Awesome. Please consider one small change.

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:39
> +enum {
> +    FindOptionsCaseInsensitive = 1 << 0,
> +    FindOptionsAtWordStarts = 1 << 1,
> +    FindOptionsTreatMedialCapitalAsWordStart = 1 << 2,
> +    FindOptionsBackwards = 1 << 3,
> +    FindOptionsWrapAround = 1 << 4,
> +    FindOptionsStartInSelection = 1 << 5
> +};

You should use something like COMPILE_ASSERT_MATCHING_ENUM from the src/WebKit/chromium source to ensure that these are equivalent to their WebCore counterparts.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.